1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141 | // experimental
#if defined(__GNUC__)
#pragma GCC system_header
#endif
#include <iostream>
unsigned long long max_counter = (unsigned long long)(2*1e3);
#include <chrono>
typedef std::chrono::high_resolution_clock::time_point time_point;
typedef std::chrono::high_resolution_clock::duration duration;
// minimizers to test
#include "Tools/Math/Optimizer.h"
// testing functions
#include "TestFunctions.h"
template<class F, template<typename, typename> class O, class T>
class Test{
public:
O<F,T> optimizer;
void operator()(const T& start, const T& eps){
F function;
T offset;
T x = start;
time_point begin;
time_point end;
duration sum = duration::zero();
unsigned long long counter = 0;
bool valid;<--- The scope of the variable 'valid' can be reduced. [+]The scope of the variable 'valid' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
do {
begin = std::chrono::high_resolution_clock::now();
valid = optimizer.minimizeOneStep(function, x, eps, offset);
end = std::chrono::high_resolution_clock::now();
sum += end - begin;
if(valid){
x += offset;
}
counter++;
} while(optimizer.error > 1e-5 && !optimizer.step_failed() && counter < max_counter);
std::cout << optimizer.getName() << ": " << function.getName() << std::endl;
std::cout << "final error : " << optimizer.error << std::endl;
std::cout << "final solution : " << x << std::endl;
std::cout << "number of steps: " << counter << std::endl;
std::cout << "average time: " << sum.count()/counter << " ns" << std::endl;
std::cout << "total time : " << sum.count() << " ns" << std::endl;
std::cout << "step failed : " << (optimizer.step_failed() ? "true" : "false") << std::endl;
std::cout << "---------------------" << std::endl;
}
};
template<class F, template<typename, typename> class O, class T>
void testDifferentialBased(const T& start, const T& eps) {
F function;
O<F,T> optimizer;
T offset;
T x = start;
time_point begin;
time_point end;
duration sum = duration::zero();
unsigned long long counter = 0;
bool valid;<--- The scope of the variable 'valid' can be reduced. [+]The scope of the variable 'valid' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
do {
begin = std::chrono::high_resolution_clock::now();
valid = optimizer.minimizeOneStep(function, x, eps, offset);
end = std::chrono::high_resolution_clock::now();
sum += end - begin;
if(valid){
x += offset;
}
counter++;
} while(optimizer.error > 1e-5 && !optimizer.step_failed() && counter < max_counter);
std::cout << optimizer.getName() << ": " << function.getName() << std::endl;
std::cout << "final error : " << optimizer.error << std::endl;
std::cout << "final solution : " << x << std::endl;
std::cout << "number of steps: " << counter << std::endl;
std::cout << "average time: " << sum.count()/counter << " ns" << std::endl;
std::cout << "total time : " << sum.count() << " ns" << std::endl;
std::cout << "step failed : " << (optimizer.step_failed() ? "true" : "false") << std::endl;
std::cout << "---------------------" << std::endl;
}
template<class F, template<typename, typename> class O, class T>
void testDifferentialBased(O<F,T> *const optimizer, const T& start, const T& eps) {
F function;
T offset;
T x = start;
time_point begin;
time_point end;
duration sum = duration::zero();
unsigned long long counter = 0;
bool valid;<--- The scope of the variable 'valid' can be reduced. [+]The scope of the variable 'valid' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
do {
begin = std::chrono::high_resolution_clock::now();
valid = optimizer->minimizeOneStep(function, x, eps, offset);
end = std::chrono::high_resolution_clock::now();
sum += end - begin;
if(valid){
x += offset;
}
counter++;
} while(optimizer->error > 1e-5 && !optimizer->step_failed() && counter < max_counter);
std::cout << optimizer->getName() << ": " << function.getName() << std::endl;
std::cout << "final error : " << optimizer->error << std::endl;
std::cout << "final solution : " << x << std::endl;
std::cout << "number of steps: " << counter << std::endl;
std::cout << "average time: " << sum.count()/counter << " ns" << std::endl;
std::cout << "total time : " << sum.count() << " ns" << std::endl;
std::cout << "step failed : " << (optimizer->step_failed() ? "true" : "false") << std::endl;
std::cout << "---------------------" << std::endl;
}
|